- 
                Notifications
    You must be signed in to change notification settings 
- Fork 468
feat(llmobs): allow versioned dataset pulling #14921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| 
  | 
| Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 238 ± 1 ms. The average import time from base is: 244 ± 4 ms. The import time difference between this PR and base is: -5.3 ± 0.1 ms. Import time breakdownThe following import paths have shrunk: 
             | 
| Performance SLOsComparing candidate gary/mlob-3837 (48e4ca9) with baseline main (5fa0681) ❌ Test Failures (1 suite)❌ telemetryaddmetric - 29/30✅ 1-count-metric-1-timesTime: ✅ 2.940µs (SLO: <20.000µs 📉 -85.3%) vs baseline: -1.6% Memory: ✅ 32.106MB (SLO: <34.000MB -5.6%) vs baseline: +4.7% ✅ 1-count-metrics-100-timesTime: ✅ 202.425µs (SLO: <220.000µs -8.0%) vs baseline: +0.6% Memory: ✅ 32.126MB (SLO: <34.000MB -5.5%) vs baseline: +4.5% ✅ 1-distribution-metric-1-timesTime: ✅ 3.301µs (SLO: <20.000µs 📉 -83.5%) vs baseline: -0.2% Memory: ✅ 32.106MB (SLO: <34.000MB -5.6%) vs baseline: +4.7% ✅ 1-distribution-metrics-100-timesTime: ✅ 214.904µs (SLO: <220.000µs -2.3%) vs baseline: -0.2% Memory: ✅ 32.185MB (SLO: <34.000MB -5.3%) vs baseline: +5.1% ✅ 1-gauge-metric-1-timesTime: ✅ 2.186µs (SLO: <20.000µs 📉 -89.1%) vs baseline: -0.2% Memory: ✅ 32.165MB (SLO: <34.000MB -5.4%) vs baseline: +4.8% ✅ 1-gauge-metrics-100-timesTime: ✅ 136.776µs (SLO: <150.000µs -8.8%) vs baseline: -0.5% Memory: ✅ 32.126MB (SLO: <34.000MB -5.5%) vs baseline: +4.9% ✅ 1-rate-metric-1-timesTime: ✅ 3.334µs (SLO: <20.000µs 📉 -83.3%) vs baseline: +8.8% Memory: ✅ 32.086MB (SLO: <34.000MB -5.6%) vs baseline: +4.5% ✅ 1-rate-metrics-100-timesTime: ✅ 223.125µs (SLO: <250.000µs 📉 -10.8%) vs baseline: +4.0% Memory: ✅ 32.204MB (SLO: <34.000MB -5.3%) vs baseline: +5.0% ✅ 100-count-metrics-100-timesTime: ✅ 20.451ms (SLO: <22.000ms -7.0%) vs baseline: -0.2% Memory: ✅ 32.106MB (SLO: <34.000MB -5.6%) vs baseline: +4.7% ❌ 100-distribution-metrics-100-timesTime: ❌ 2.313ms (SLO: <2.300ms +0.6%) vs baseline: +1.9% Memory: ✅ 32.165MB (SLO: <34.000MB -5.4%) vs baseline: +4.9% ✅ 100-gauge-metrics-100-timesTime: ✅ 1.412ms (SLO: <1.550ms -8.9%) vs baseline: +0.2% Memory: ✅ 32.204MB (SLO: <34.000MB -5.3%) vs baseline: +5.0% ✅ 100-rate-metrics-100-timesTime: ✅ 2.222ms (SLO: <2.550ms 📉 -12.9%) vs baseline: -0.3% Memory: ✅ 32.204MB (SLO: <34.000MB -5.3%) vs baseline: +4.9% ✅ flush-1-metricTime: ✅ 4.894µs (SLO: <20.000µs 📉 -75.5%) vs baseline: +8.7% Memory: ✅ 32.145MB (SLO: <34.000MB -5.5%) vs baseline: +4.7% ✅ flush-100-metricsTime: ✅ 175.199µs (SLO: <250.000µs 📉 -29.9%) vs baseline: +0.3% Memory: ✅ 32.165MB (SLO: <34.000MB -5.4%) vs baseline: +4.9% ✅ flush-1000-metricsTime: ✅ 2.112ms (SLO: <2.500ms 📉 -15.5%) vs baseline: +0.3% Memory: ✅ 32.932MB (SLO: <34.500MB -4.5%) vs baseline: +4.9% 🟡 Near SLO Breach (3 suites)🟡 djangosimple - 30/30✅ appsecTime: ✅ 20.475ms (SLO: <22.300ms -8.2%) vs baseline: -0.1% Memory: ✅ 65.250MB (SLO: <67.000MB -2.6%) vs baseline: +4.9% ✅ exception-replay-enabledTime: ✅ 1.347ms (SLO: <1.450ms -7.1%) vs baseline: +0.1% Memory: ✅ 64.552MB (SLO: <67.000MB -3.7%) vs baseline: +4.6% ✅ iastTime: ✅ 20.494ms (SLO: <22.250ms -7.9%) vs baseline: -0.2% Memory: ✅ 65.197MB (SLO: <67.000MB -2.7%) vs baseline: +4.8% ✅ profilerTime: ✅ 15.299ms (SLO: <16.550ms -7.6%) vs baseline: +0.3% Memory: ✅ 53.847MB (SLO: <54.500MB 🟡 -1.2%) vs baseline: +4.9% ✅ resource-renamingTime: ✅ 20.491ms (SLO: <21.750ms -5.8%) vs baseline: -0.3% Memory: ✅ 65.194MB (SLO: <67.000MB -2.7%) vs baseline: +4.8% ✅ span-code-originTime: ✅ 25.398ms (SLO: <28.200ms -9.9%) vs baseline: ~same Memory: ✅ 67.373MB (SLO: <69.500MB -3.1%) vs baseline: +4.5% ✅ tracerTime: ✅ 20.395ms (SLO: <21.750ms -6.2%) vs baseline: -0.5% Memory: ✅ 65.136MB (SLO: <67.000MB -2.8%) vs baseline: +4.6% ✅ tracer-and-profilerTime: ✅ 22.103ms (SLO: <23.500ms -5.9%) vs baseline: +0.3% Memory: ✅ 66.771MB (SLO: <67.500MB 🟡 -1.1%) vs baseline: +5.0% ✅ tracer-dont-create-db-spansTime: ✅ 19.305ms (SLO: <21.500ms 📉 -10.2%) vs baseline: ~same Memory: ✅ 65.232MB (SLO: <66.000MB 🟡 -1.2%) vs baseline: +4.8% ✅ tracer-minimalTime: ✅ 16.525ms (SLO: <17.500ms -5.6%) vs baseline: -0.5% Memory: ✅ 65.168MB (SLO: <66.000MB 🟡 -1.3%) vs baseline: +4.7% ✅ tracer-nativeTime: ✅ 20.496ms (SLO: <21.750ms -5.8%) vs baseline: -0.3% Memory: ✅ 70.995MB (SLO: <72.500MB -2.1%) vs baseline: +4.8% ✅ tracer-no-cachesTime: ✅ 18.409ms (SLO: <19.650ms -6.3%) vs baseline: -0.3% Memory: ✅ 65.210MB (SLO: <67.000MB -2.7%) vs baseline: +4.8% ✅ tracer-no-databasesTime: ✅ 18.738ms (SLO: <20.100ms -6.8%) vs baseline: -0.2% Memory: ✅ 65.197MB (SLO: <67.000MB -2.7%) vs baseline: +4.8% ✅ tracer-no-middlewareTime: ✅ 20.101ms (SLO: <21.500ms -6.5%) vs baseline: -0.4% Memory: ✅ 65.174MB (SLO: <67.000MB -2.7%) vs baseline: +4.9% ✅ tracer-no-templatesTime: ✅ 20.332ms (SLO: <22.000ms -7.6%) vs baseline: ~same Memory: ✅ 65.192MB (SLO: <67.000MB -2.7%) vs baseline: +4.8% 🟡 errortrackingdjangosimple - 6/6✅ errortracking-enabled-allTime: ✅ 18.273ms (SLO: <19.850ms -7.9%) vs baseline: +1.3% Memory: ✅ 65.216MB (SLO: <66.500MB 🟡 -1.9%) vs baseline: +4.9% ✅ errortracking-enabled-userTime: ✅ 18.301ms (SLO: <19.400ms -5.7%) vs baseline: +1.3% Memory: ✅ 65.186MB (SLO: <66.500MB 🟡 -2.0%) vs baseline: +4.8% ✅ tracer-enabledTime: ✅ 18.163ms (SLO: <19.450ms -6.6%) vs baseline: +0.6% Memory: ✅ 65.254MB (SLO: <66.500MB 🟡 -1.9%) vs baseline: +4.9% 🟡 flasksimple - 18/18✅ appsec-getTime: ✅ 4.573ms (SLO: <4.750ms -3.7%) vs baseline: ~same Memory: ✅ 62.030MB (SLO: <65.000MB -4.6%) vs baseline: +5.0% ✅ appsec-postTime: ✅ 6.612ms (SLO: <6.750ms -2.0%) vs baseline: -0.3% Memory: ✅ 61.912MB (SLO: <65.000MB -4.8%) vs baseline: +4.7% ✅ appsec-telemetryTime: ✅ 4.582ms (SLO: <4.750ms -3.5%) vs baseline: -0.2% Memory: ✅ 61.932MB (SLO: <65.000MB -4.7%) vs baseline: +4.9% ✅ debuggerTime: ✅ 1.859ms (SLO: <2.000ms -7.0%) vs baseline: +0.3% Memory: ✅ 45.475MB (SLO: <47.000MB -3.2%) vs baseline: +4.8% ✅ iast-getTime: ✅ 1.861ms (SLO: <2.000ms -6.9%) vs baseline: -0.2% Memory: ✅ 42.408MB (SLO: <49.000MB 📉 -13.5%) vs baseline: +4.9% ✅ profilerTime: ✅ 1.915ms (SLO: <2.100ms -8.8%) vs baseline: -0.3% Memory: ✅ 46.458MB (SLO: <47.000MB 🟡 -1.2%) vs baseline: +4.8% ✅ resource-renamingTime: ✅ 3.373ms (SLO: <3.650ms -7.6%) vs baseline: +0.3% Memory: ✅ 52.298MB (SLO: <53.500MB -2.2%) vs baseline: +4.9% ✅ tracerTime: ✅ 3.358ms (SLO: <3.650ms -8.0%) vs baseline: ~same Memory: ✅ 52.180MB (SLO: <53.500MB -2.5%) vs baseline: +4.7% ✅ tracer-nativeTime: ✅ 3.357ms (SLO: <3.650ms -8.0%) vs baseline: ~same Memory: ✅ 58.260MB (SLO: <60.000MB -2.9%) vs baseline: +4.8% 
 | 
ee5feda    to
    6cf1a5a      
    Compare
  
    e0457da    to
    bfb9164      
    Compare
  
    There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm as-is (aside from updating the release note), just a clarification and a couple suggestions!
        
          
                releasenotes/notes/llmobs-dne-allow-versioned-dataset-pull-c7017f982b2c1f5b.yaml
              
                Outdated
          
            Show resolved
            Hide resolved
        
      4706ddd    to
    464a64f      
    Compare
  
    02f04b8    to
    a39d9a4      
    Compare
  
    …17f982b2c1f5b.yaml Co-authored-by: Sam Brenner <[email protected]>
a39d9a4    to
    48e4ca9      
    Compare
  
    
Description
this PR allows users to optionally pull a specific version of a dataset by specifying the version in the
pull_datasetcallTesting
with the following script to first pull the latest version, then a specified version, and a non existent version, we get the following output:
output:
the number of entries match the different versions of the dataset: https://dddev.datadoghq.com/llm/datasets/a68e7967-9d2b-4171-a887-f55ba4dbfe5e
Risks
Additional Notes